MSS icon indicating copy to clipboard operation
MSS copied to clipboard

2688 refactor kml dockwidget

Open levi178u opened this issue 8 months ago • 3 comments

Purpose of PR?:

Fixes #2688

Changes committed :

  • Update fastkml KML parsing for compatibility with version >=1.0.0
  • Replaced deprecated .from_string() usage and added encoding to ensure compatibility with fastkml 1.0.0.

levi178u avatar Apr 12 '25 06:04 levi178u

https://github.com/Open-MSS/MSS/pull/2786#issuecomment-2788531990

This was short living:

"I'll follow this and make sure to never repeat the same"

It seems you are unwilling https://github.com/Open-MSS/MSS/pull/2797

ReimarBauer avatar Apr 12 '25 07:04 ReimarBauer

#2786 (comment)

This was short living:

"I'll follow this and make sure to never repeat the same"

It seems you are unwilling #2797

Sir actually I'm beginner and I read the github docs and studied the rules and methods as you mentioned. I used git pull to fetch all changes and created a separate branch for pushing changes in new issue, but I was really unaware how these commits too got pushed, so I created a draft pr here. My apologies but as I'm learning about pr workflows these errors occur sometimes, pls bear with me

levi178u avatar Apr 12 '25 07:04 levi178u

Yes @ReimarBauer ,done with the updates, now it shows only 1 file changed and I rebased it to develop too. Thx for ur patience :)

levi178u avatar Apr 12 '25 09:04 levi178u

was solved by https://github.com/Open-MSS/MSS/pull/2833

ReimarBauer avatar Jul 17 '25 12:07 ReimarBauer