MSS icon indicating copy to clipboard operation
MSS copied to clipboard

unexpected argument in dataaccess

Open ReimarBauer opened this issue 8 months ago • 5 comments

the signature of def _determine_filename(self, variable, vartype, init_time, valid_time) is different to its usage in dataaccess.have_data with variable, vartype, init_time, valid_time, reload=False)

The functionality is not directly covered by a test. A test needs to become added too.

ReimarBauer avatar Mar 31 '25 06:03 ReimarBauer

The implementations of that method actually do have the correct signature, it is just that the method prototype in the abstract base class is missing it.

matrss avatar Mar 31 '25 08:03 matrss

Does this look good?

divyaajainn avatar Mar 31 '25 09:03 divyaajainn

Does this look good?

Is it possible to add a test for the reload functionality?

ReimarBauer avatar Mar 31 '25 12:03 ReimarBauer

yes I’ll add one.

divyaajainn avatar Apr 02 '25 18:04 divyaajainn

Hii! , thanks for the information . i wanna contribute to this issue too. i'll be glad if my contribution will be helpful.

praharsh777 avatar Apr 06 '25 17:04 praharsh777