MSS
MSS copied to clipboard
Open-MSS
problem in get_projection_params
after the raise that code is unreachable
https://github.com/Open-MSS/MSS/blame/develop/mslib/utils/get_projection_params.py#L45 https://github.com/Open-MSS/MSS/blob/develop/mslib/utils/get_projection_params.py#L64
The function was moved, that can be also fixed in stable and I redo the changes at merge time if needed.
@ReimarBauer Are AUTO and AUTO2 projections intended to be supported, or should the raise stay and the unreachable code be removed?
@ReimarBauer Are AUTO and AUTO2 projections intended to be supported, or should the raise stay and the unreachable code be removed?
I have no idea. That´s why I think it is a task for Joern because he is familiar with that math.
These are projections described in the WMS standards, e.g. here https://portal.ogc.org/files/?artifact_id=14416 I do not know why we do not support them (judging from the raise ValueError).
This commit 71de73e98b49be53f59f501f066052bfb5e8ea77 tried to make MSWMS more standards compliant in this regard. The message indicates "AUTO/AUTO2 projections are not yet supported due to technical difficulties in basemap", which isn't a lot of information. basemap hasn't really changed in the last seven years, so if the statement was true, this likely hasn't changed. On the other hand, I do not immediately see why we couldn't work around basemaps problems...?
I personally would leave this code in there as minder and maybe add an issue to revisit this?
personally would leave this code in there as minder and maybe add an issue to revisit this?
pylint or similiar will always show the lines as not reachable. We maybe should comment them and add a hint to the issue. Also it would be good to add an issue what we need in basemap https://github.com/matplotlib/basemap When we have on basemap an issue about Auto/Auto2 we can link it here and label this one with Upstream Fix needed.
What do you think?