Open-MSS
Develop
-
Further refactoring of mscolab
-
Move (most) communication with server to ConnectionManager class to have consistent calls and error handling (e.g. timeout).
-
More consistently use json() method of response.
-
Removed single letter variables.
-
Update mscolab_exceptions.py
update copyright string
Co-authored-by: ReimarBauer [email protected]
Purpose of PR?:
Fixes #2516
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes? If yes, include the list of Documentation changes
Checklist:
- [x] Bug fix. Fixes #
- [x] New feature (Non-API breaking changes that adds functionality)
- [x] PR Title follows the convention of
<type>: <subject> - [x] Commit has unit tests
Purpose of PR?:
Fixes #
Does this PR introduce a breaking change?
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? : Mention if this PR is part of any design or a continuation of previous PRs
Does this PR results in some Documentation changes? If yes, include the list of Documentation changes
Checklist:
- [ ] Bug fix. Fixes #
- [ ] New feature (Non-API breaking changes that adds functionality)
- [ ] PR Title follows the convention of
<type>: <subject> - [ ] Commit has unit tests
Hi @sarthakvyas16 please can you send this change to our stable branch. We want this in the next minor or patch level release. The next major will need some more time.
Please also use a meaningful name for the PR string.
Hi @ReimarBauer
I’ll go ahead and send this change to the stable branch. I’ll also come up with a meaningful name for the PR string.
Thanks for the update.