MSS icon indicating copy to clipboard operation
MSS copied to clipboard

more colors in textual output

Open ReimarBauer opened this issue 1 year ago • 3 comments

There is a red warning and 3 white Warning, and the Info Text is orange

image

I think we should have all warnings in the same color, different to info but not white, as in this example

ReimarBauer avatar Sep 02 '24 16:09 ReimarBauer

I agree with you, I also noticed that the RED warning is actually an INFO statement from the application's point of view. I am interested in taking a look, could you assign this issue to me ?

anshulagrawal2902 avatar Dec 28 '24 17:12 anshulagrawal2902

I was looking into this and I don't understand why are we not using a singleton logger instance. I saw definition for the setup_logger function, but we rarely use it. Most modules have an import logging statement and they are using the root logger. This makes it difficult to make changes like the one in this issue. Either I misunderstood it or I am lacking context. Regardless, I would appreciate your view on the problem.

anshulagrawal2902 avatar Dec 28 '24 19:12 anshulagrawal2902

The whole thing has simply grown over 10 years and currently most of the tasks for MSS are to refactor it and increase stability. We have to make sure that we can e.g. suppress the matplotlib logger and output all our logging messages. That is much easier by a singleton and logging definitions so that different users can use their own.

ReimarBauer avatar Dec 30 '24 12:12 ReimarBauer