MSS icon indicating copy to clipboard operation
MSS copied to clipboard

Published 20 hours ago • verified publisher icon Open-MSS

review and refactor usage of lamba in QObject connect

Open ReimarBauer opened this issue 1 year ago • 4 comments

On some of the QObjects we use connect with a lambda function. This is likly not correct and needs to be verified. It surpresses the capabilty of QT to check if a slot exists. Test coverage should become checked too.

Prefered solution without lambda.

Also a lot of these signals are duplicated. Likly that is not needed when the mainwindow gets referenced in the multiple_flightpath docking widget.

ReimarBauer avatar Apr 15 '24 10:04 ReimarBauer

can i work on this @ReimarBauer

rohit2p avatar Apr 18 '24 16:04 rohit2p

You can but it is likly a larger refactoring and the tests are not completed yet, see https://github.com/Open-MSS/MSS/pull/2326#discussion_r1570130199

ReimarBauer avatar Apr 18 '24 16:04 ReimarBauer

Okey

rohit2p avatar Apr 18 '24 18:04 rohit2p

Start with referencing the mainwindow in the other components then remove duplicated code parts. Some hints are in the linked PR.

ReimarBauer avatar Apr 19 '24 06:04 ReimarBauer