OCCT icon indicating copy to clipboard operation
OCCT copied to clipboard

Published 20 hours ago • verified publisher icon Open-Cascade-SAS

Update permission draw.sh

Open ThmsP opened this issue 1 year ago • 1 comments
trafficstars

Hello, Currently, the file draw.sh is installed with very open permissions (777). This is probably not a problem for a user installation but we package it with rpm and thus it leaves a root owned file with very insecure permissions. I have a very limited view of the project thus I may be missing the point of this permissions.

ThmsP avatar Feb 26 '24 16:02 ThmsP

Hello, thank you for the patch. We will analyze it. Our main bug tracker is https://tracker.dev.opencascade.org/my_view_page.php PR in OCCT for read only.

dpasukhi avatar Mar 15 '24 12:03 dpasukhi

@ThmsP There an new issue for your ticket https://tracker.dev.opencascade.org/view.php?id=33749 We will proceed with your PR after your signing CLA - https://dev.opencascade.org/get_involved _ OCCT GitHub repo going to have write access.

dpasukhi avatar Jun 27 '24 10:06 dpasukhi

@dpasukhi : Hello, I just signed and send the CLA.

ThmsP avatar Jun 27 '24 16:06 ThmsP

Great. I will initiate the test procedure. After full test cycle the issue will be integrated into IR-1 then it will be integrated into master.

dpasukhi avatar Jun 27 '24 17:06 dpasukhi

Tests are success: http://jenkins-test-10.nnov.opencascade.com/view/CR33752-master-dpasukhi/view/COMPARE/

dpasukhi avatar Jun 28 '24 08:06 dpasukhi

Thanks !

ThmsP avatar Jun 28 '24 09:06 ThmsP

@ThmsP the CLA was filled up with some mistakes. I will keep changes in IR branch for some time waiting for your CLA update.

dpasukhi avatar Jun 28 '24 10:06 dpasukhi

@ThmsP if you mind to share your personal data. Could I change the author of this comment to OpenCascade? I have no option to allow merge your commit without correct CLA :(

dpasukhi avatar Jul 04 '24 10:07 dpasukhi

@dpasukhi Sorry, I just send a correctly filled form.

ThmsP avatar Jul 04 '24 13:07 ThmsP