Open-Cap-Format-OCF icon indicating copy to clipboard operation
Open-Cap-Format-OCF copied to clipboard

commits a formatting diff coming from the hooks

Open osis opened this issue 1 year ago • 4 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Noticing that these files get reformatted when running the pre-commit hooks without any other changes to the codebase. It's very distracting when trying to get other changes in.

I confirmed that my IDE isn't getting in the way and doing some reformatting on its own, but would probably want as least one other person to confirm this is happening as well.

osis avatar Feb 27 '24 16:02 osis

after going down a bit of a rabbithole, this is due to the lint-staged cmd being broken in the pre-commit hook. Will submit a fix.

osis avatar Feb 27 '24 17:02 osis

Hmmmm interesting. lint-staged wasn't working for me regardless. I'll return the PR back to it's original state so you can see for yourself.

osis avatar Feb 27 '24 22:02 osis

Hmmmm interesting. lint-staged wasn't working for me regardless. I'll return the PR back to it's original state so you can see for yourself.

This is probably on me, but I read this as a different problem than what was originally stated, and doesn't answer my question.

Can you please write a "Bug" issue and fill out that template so I know what we're trying to fix?

pjohnmeyer avatar Feb 27 '24 22:02 pjohnmeyer

Sorry for the lack of clarity @pjohnmeyer. "These files" refers to the files affected in this PR. More details in #476 as requested.

osis avatar Feb 28 '24 02:02 osis