Onion icon indicating copy to clipboard operation
Onion copied to clipboard

Update mGBA core.

Open twoco opened this issue 2 years ago • 4 comments

Checklist

  • [X] I am reporting a bug in the Onion OS - Any issues with the closed source frontend (MainUI), or RetroArch or any of the cores should be directed to their respective repositories
  • [X] I have reviewed the Onion Wiki and did not find the answer
  • [X] I have searched the existing (open and closed) issues to ensure I do not log a duplicate

Onions OS Version

v4.2.0-RC-snapshot-a5064207

Miyoo Firmware Version

202305052130

Provide a clear and concise description of the issue

The current mGBA core 0.10-dev ec5ecb2 has an issue of flickering sprites. The commit is from Oct 25, 2022. I would test the latest version 0.10.2 2fb5545 from Apr 24, 2023. But I have no idea how to update it. Or who compiles this for the Miyoo Mini? Is this the right place here?

Steps to Reproduce

Run the game "Mario And Luigi Superstar Saga" in mGBA and see flickering sprites e.g. in the intro scene.

Provide any additional context or information that may help us investigate your issue

To fix the issue, we have to test with the latest version. Maybe this will resolve the problem or we file a bug report. Btw. I tested it with the gpSP core without that problems. Why is gpSP not in verified list?

twoco avatar Aug 05 '23 06:08 twoco

Please test this:

Ignore this - mgba branch closed as there's other changes to source i wasn't aware of :)

Also just FYI, i tested just now and it didn't fix the flickering.

XK9274 avatar Aug 05 '23 14:08 XK9274

Yes, unfortunately it‘s not fixed. The sprites are still flickering. And moreover the game runs now in stop motion most of time. ca. 1 FPS, Unplayable (Miyoo Mini Plus). Anyway, thanks for compiling and testing too. …

twoco avatar Aug 05 '23 20:08 twoco

Installed Onion on my MM+ the other day and am experiencing the same issue with sprites flickering in Mario & Luigi Superstar Saga with the mGBA core. gpSP does not have this issue and seems to be running fine. I suppose it is a non-issue since gpSP works, but it would be great if this wasn't an issue with the "out of the box" Onion install. I'd be happy to help test a newer mGBA core if needed.

wlowen avatar May 21 '24 02:05 wlowen

@TwisX

It's an issue with Game Boy Player/Rumble that's enabled by default in core settings. Disabling that fixes it.

Best way I've found to apply the change:

  • Load game
  • Quick Menu > Core Options > Input & Auxiliary Devices > Game Boy Player Rumble (toggle off)
  • Close Content (in Quick Menu)
  • Quit Retroarch
  • Navigate back to the game and open the GLO menu (Y button)
  • Reset game

You'll see the changes have taken effect. It automatically saves to mgba.opt as mgba_force_gbp = "OFF", so no need to save any overrides.

This setting should really be set to off by default imo. More people are likely to complain about sprite flickering over lack of rumble in a GBA game, and if they choose to enable rumble the warning is right there.

Gusfit1 avatar Dec 15 '24 23:12 Gusfit1