oneflow icon indicating copy to clipboard operation
oneflow copied to clipboard

refine error message for framework

Open farmerzhang1 opened this issue 3 years ago • 3 comments
trafficstars

为framework完善报错信息 修改文件如下:

  • arg_tuple.cpp
  • attr_map.cpp
  • consistency_check.cpp
  • device.cpp
  • infer_util.cpp
  • instruction_builder.cpp
  • local_tensor_infer_cache.cpp
  • multi_client_session_context.cpp
  • nd_sbp.cpp
  • nn_graph.cpp
  • sync_symbol_parallel_desc.cpp

修复functional中expand functor的一个类型错误

由于framework的检查不好对应到python代码中,单元测试仅写了分布式下placement不一致的情况

farmerzhang1 avatar Sep 16 '22 09:09 farmerzhang1

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Sep 16 '22 09:09 CLAassistant

Uploading image.png… 点击下这个图标,按照提示把 CLA 签了吧

doombeaker avatar Sep 21 '22 02:09 doombeaker

CI 需要紫色、绿色标签类的,起码各一个。那个 “need-check-error-msg”是和 CI 功能有关的标签,应该是启动一般不用多检查,我不确定你这个PR是否用得上,先取消了(黑色标签应该都是)

doombeaker avatar Sep 21 '22 02:09 doombeaker

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

github-actions[bot] avatar Sep 23 '22 09:09 github-actions[bot]

Code got formatted by CI. Please request CI again if you still want to have this PR merged. If the PR is from a forked repo, please download the patch files from the GitHub Actions web page and apply them locally.

github-actions[bot] avatar Sep 23 '22 11:09 github-actions[bot]

Speed stats:
GPU Name: GeForce GTX 1080 









❌ OneFlow resnet50 time: 140.2ms (= 14023.6ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 161.1ms (= 16112.7ms / 100, input_shape=[16, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.15 (= 161.1ms / 140.2ms)

OneFlow resnet50 time: 85.6ms (= 8556.4ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 102.8ms (= 10284.5ms / 100, input_shape=[8, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.20 (= 102.8ms / 85.6ms)

OneFlow resnet50 time: 58.1ms (= 11629.0ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 78.7ms (= 15748.4ms / 200, input_shape=[4, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.35 (= 78.7ms / 58.1ms)

OneFlow resnet50 time: 45.6ms (= 9121.6ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 80.0ms (= 15999.3ms / 200, input_shape=[2, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.75 (= 80.0ms / 45.6ms)

OneFlow resnet50 time: 39.1ms (= 7819.0ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
PyTorch resnet50 time: 76.7ms (= 15341.3ms / 200, input_shape=[1, 3, 224, 224], ddp, world size=2)
✔️ Relative speed: 1.96 (= 76.7ms / 39.1ms)

github-actions[bot] avatar Sep 23 '22 13:09 github-actions[bot]

View latest API docs preview at: https://staging.oneflow.info/docs/Oneflow-Inc/oneflow/pr/9104/

github-actions[bot] avatar Sep 23 '22 13:09 github-actions[bot]