OZtree icon indicating copy to clipboard operation
OZtree copied to clipboard

Search code looks at sponsorship text but not verified sponsorship text

Open jrosindell opened this issue 3 years ago • 4 comments

So it brings up sponsored leaves based on the text entered by users even if that text is not live on the tree. It should only be for live leaves and should use the verified text only.

jrosindell avatar Dec 23 '21 00:12 jrosindell

For example, someone put text about "Donald Trump" into sponsorship that has not yet been verified, and we get this on when searching for that on the main page:

Screenshot 2021-12-23 at 10 12 57

hyanwong avatar Dec 23 '21 10:12 hyanwong

This is an issue because if someone puts in an obnoxious name or sponsors a dodgy species that should have been banned it will be highlighted in search before the data entered has been vetted

jrosindell avatar Mar 13 '22 08:03 jrosindell

This was mostly solved by throwing away code. But I've added a bunch more tests whilst looking at this.

lentinj avatar Mar 14 '22 17:03 lentinj

Perfect, thanks. That's the ideal solution: increases the test:code ratio both ways

hyanwong avatar Mar 14 '22 17:03 hyanwong