oneuptime icon indicating copy to clipboard operation
oneuptime copied to clipboard

Enhancement: Add a way to disable chart dependencies.

Open kashalls opened this issue 2 years ago • 4 comments

Issue cross posted from https://github.com/OneUptime/helm-chart/issues/1

Thanks for working on getting this helm chart published. It makes it easier to manage this instead of a huge glob of manifests. We do have some issues that needs to be sorted out.

  1. Some of the additional charts included in this chart need a way to be disabled.

Clickhouse, Minio, Postgres and Redis are already scaled services I run. Postgres and Redis are widely available as managed services by hosting companies so it would make sense to that over a small one in this chart. This would need to basically have an option where you can set enabled as a boolean and configure some other things on where to connect, how to connect, connect with special options (redis with sentinel?).

  1. I'm not entirely sure why we need metallb in a helmchart?

  2. There is no way to pass secret data. Environment variables like the ones in example.env, are unsettable here.

It's true that they are added here. But it simply generates a random string, unless these need to be changing every time you deploy this chart.

A good alternative would be to allow users to create a Secret/ConfigMap called oneuptime-config for the helmchart to read from instead of hardcoding stuff in helpers.tpl

  1. It might be a good idea to explore alternatives to running a nginx container in kubernetes when you can take advantage of other options like traefik, ingress-nginx, or the built-in endpoints that I haven't taken a look into.

All in all, good job on the chart! Glad it is being pushed, a lot of the OSS homelabbers will be happy to stop updating 25 oneuptime containers every day. :)

kashalls avatar Oct 18 '23 04:10 kashalls