oneuptime icon indicating copy to clipboard operation
oneuptime copied to clipboard

Offline criteria did not create incident when web is unavailable

Open JanRajnoha opened this issue 1 year ago • 16 comments

Describe the bug Everytime when is my web unavailable, monitor will recognize correctly, that something is wrong, but incident is not created. Option to automatic resolve is unchecked.

To Reproduce Steps to reproduce the behavior:

  1. Set criteria to create incident when web is unavailable
  2. Make web unavailable (not manually trigger criteria)
  3. Incident is not created

Expected behavior Incident is created and is not resolved automatically, when web is again online

Screenshots image

Desktop (please complete the following information):

  • OS: Windows
  • Browser: Edge
  • Version: Current Canary version

JanRajnoha avatar Aug 15 '23 12:08 JanRajnoha

@JanRajnoha do you have the incident already active for that monitor? If so, we dont create another incident.

simlarsen avatar Aug 15 '23 15:08 simlarsen

No, there is not any incident at all.

JanRajnoha avatar Aug 16 '23 08:08 JanRajnoha

@JanRajnoha is this on a self hosted instance or SaaS? Can I have the monitor id?

simlarsen avatar Aug 16 '23 10:08 simlarsen

It is SaaS and monitor ID is 4a7a3a97-ffc4-476c-9605-0ce276ce81c8

JanRajnoha avatar Aug 16 '23 15:08 JanRajnoha

@JanRajnoha Thank you for this. Investigating. Will get back to you by EOD today.

simlarsen avatar Aug 17 '23 10:08 simlarsen

@JanRajnoha You need to add Response Status Coide as a part of your criteria. You only have Is Online which will be true even if the server returns 500. As long as server responds to a request and does not timeout Is Online will be true.

simlarsen avatar Aug 17 '23 16:08 simlarsen

I added check for status code != 200 and switch filters to Any, but nothing changed. Monitor is still switching to offline (as before), but incident is still not created

So I changed status from Offline to Degraded, to be sure that criteria is met and monitor switched to Degraded status -> everything is okay to pint with incident -> none has been created.

Both parts are saying "when this criteria is met". So if one is working, other has to too. image

JanRajnoha avatar Aug 18 '23 09:08 JanRajnoha

Could you please look at it? @simlarsen

JanRajnoha avatar Aug 18 '23 10:08 JanRajnoha

@JanRajnoha looking into it.

simlarsen avatar Aug 18 '23 10:08 simlarsen

I dont think you added the response code filters. These are the only ones that show up:

image

simlarsen avatar Aug 23 '23 16:08 simlarsen

I'm sorry, but you did not read my previous message.

I added check for status code != 200 and switch filters to Any, but nothing changed. Monitor is still switching to offline (as before), but incident is still not created

Or you want to say, that monitor will trigger (in current state) offline status, but not create incident? Monitor is working as should, but incidents are not created. I see in my monitor, that service is down like I should, but nothing else.

I'm simulating, that service is down currently. In one hour probably results will be visible in monitor, you could check AGAIN that nothing will happen.

JanRajnoha avatar Aug 25 '23 15:08 JanRajnoha

Current state: image image

JanRajnoha avatar Aug 25 '23 18:08 JanRajnoha

@JanRajnoha Can you please also share screenshot of criteria page?

simlarsen avatar Aug 25 '23 18:08 simlarsen

image

JanRajnoha avatar Aug 25 '23 19:08 JanRajnoha

It is working for offline too (changing status), but incident don't create

JanRajnoha avatar Aug 25 '23 19:08 JanRajnoha

I tried different criteria: image Same result -> status changed correctly, but incident has not been created

JanRajnoha avatar Aug 25 '23 21:08 JanRajnoha