react-native-onesignal icon indicating copy to clipboard operation
react-native-onesignal copied to clipboard
verified publisher icon OneSignal

Android: on destroy, set this.registeredEvents = false;

Open slorber opened this issue 7 years ago • 2 comments

for android RN restart issue: https://github.com/geektimecoil/react-native-onesignal/issues/583

This change is Reviewable

slorber avatar Aug 03 '18 09:08 slorber

the new release seems to work fine for me so this fix is probably not needed anymore see https://github.com/geektimecoil/react-native-onesignal/issues/583

slorber avatar Aug 10 '18 17:08 slorber

@slorber Thanks for the PR and following up!

@slorber @Nightsd01 Can you test if pressing the back button to close the app then opening a notification still properly fires the open event to the javascript side? This is the only edge case I can think. If this is not an issue then I think we can close this PR.

For future reference this builds on PR #592.

jkasten2 avatar Aug 24 '18 04:08 jkasten2