react-native-onesignal icon indicating copy to clipboard operation
react-native-onesignal copied to clipboard

Merge major_release_5.0.0 into main

Open jennantilla opened this issue 1 year ago • 1 comments

Description

One Line Summary

This PR will merge major_release_5.0.0 changes into main.

Details

See here for a comparison of this branch vs. major_release_5.0.0.. After this PR, main and major_release_5.0.0 should be equivalent.

Note: main and user model diverged on January 4, 2023.

I have compared all changes on main and cherry-picked the merge commits.

To make the main branch reflect v5.x.x., the "old" main branch is maintained in branch 3.x.x_patch_branch.

Testing

Manual testing

Built and ran new branch on Android 13 emulator and iOS 17.2 emulator. Tested various methods to ensure everything is working.

Checklist

Overview

  • [X] I have filled out all REQUIRED sections above
  • [X] PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • [X] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [X] I have included test coverage for these changes, or explained why they are not needed
  • [X] All automated tests pass, or I explained why that is not possible
  • [X] I have personally tested this on my device, or explained why that is not possible

Final pass

  • [X] Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • [X] I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

jennantilla avatar Feb 12 '24 21:02 jennantilla

Noting that this PR should be rebased and merged last after these PRs are merged into major_release_5.0.0: https://github.com/OneSignal/react-native-onesignal/pull/1627 https://github.com/OneSignal/react-native-onesignal/pull/1649

jennantilla avatar Feb 19 '24 19:02 jennantilla