react-native-onesignal icon indicating copy to clipboard operation
react-native-onesignal copied to clipboard

[Qualityathon]: test - static analysis - format

Open fhboswell opened this issue 2 years ago • 0 comments

Description

One Line Summary

Adding testing static analysis and code formatting for the Qualityathon

Details

Motivation

Testing, static analysis and code formatting as part of git actions and precommit hooks will improve the quality of the code that gets pulled into the project.

Scope

Testing will be done with Jest Static Analysis will be done with eslint Formatting will be done with prettier

Affected code checklist

  • [x] Testing, static analysis and code formatting as part of git actions and precommit hooks will improve the quality of the code that gets pulled into the project.

Checklist

Overview

  • [x] I have filled out all REQUIRED sections above
  • [x] PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • [x] Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • [x] I have included test coverage for these changes, or explained why they are not needed
  • [x] All automated tests pass, or I explained why that is not possible
  • [ ] I have personally tested this on my device, or explained why that is not possible

Final pass

  • [ ] Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • [ ] I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

fhboswell avatar Aug 30 '22 19:08 fhboswell