OneSignal-WordPress-Plugin icon indicating copy to clipboard operation
OneSignal-WordPress-Plugin copied to clipboard

Enhance OneSignal widget to reflect signup status

Open davisshaver opened this issue 5 years ago • 3 comments

New JS approach based on official docs: https://documentation.onesignal.com/docs/web-push-custom-code-examples#section-custom-link-permission-message

  • Allows for multiple widgets on page
  • Provides new "loading" message while subscription status retrieved
  • Changes message/action based on subscription status
  • Allows unsubscription message to be changed with widget
  • Uses textwidget class for better default styling

This change is Reviewable

davisshaver avatar Nov 30 '19 14:11 davisshaver

Thanks so much for your work on this! Let us know as soon as the PR is ready for review and we'll try to review asap

rgomezp avatar Dec 09 '19 23:12 rgomezp

Thank you @rgomezp, this is ready for review. I have updated the branch to include the recent changes for VIP.

davisshaver avatar Jan 19 '20 10:01 davisshaver

The reason this hasn't been merged is due to limited bandwidth and because it still requires testing and approval by WP VIP team.

I don't want to close it so that it doesn't get lost

rgomezp avatar Nov 28 '23 18:11 rgomezp