OneSignal-WordPress-Plugin icon indicating copy to clipboard operation
OneSignal-WordPress-Plugin copied to clipboard

"Subscribe" widget should also recognize subscription status

Open davisshaver opened this issue 5 years ago • 5 comments

Description: Using the "OneSignal" widget to place subscription link. Should text change or widget should be hidden if user is already subscribed?

Steps to Reproduce Issue:

  • Place the "OneSignal" widget on the site
  • Subscribe to notifications using the widget
  • Reload page
  • Click link again - no action triggered, no indication that user is already subscribed

Anything else:

davisshaver avatar Nov 19 '19 12:11 davisshaver

@rgomezp Could you let me know your thoughts on this? Would it be something the core team is interested in prioritizing? If not, would you accept a pull request?

davisshaver avatar Nov 24 '19 16:11 davisshaver

@davisshaver , I'm sorry. I don't understand the question. What is the issue? If you would like to try the upcoming version of the plugin, you can download it here.

rgomezp avatar Dec 09 '19 23:12 rgomezp

@rgomezp The widget is a static text link. According to the docs linked above, "We highly recommend only showing this custom Prompt and link if the user is unsubscribed." The pull request in draft here is a work-in-progress to do this: https://github.com/OneSignal/OneSignal-WordPress-Plugin/pull/220

Maybe someone on team could help review?

davisshaver avatar Dec 09 '19 23:12 davisshaver

@davisshaver , Thank you for your contributions. We will take a look for the next version of the plugin

rgomezp avatar Jan 28 '20 00:01 rgomezp

Is this already implemented

amanijoseph87 avatar Sep 06 '21 14:09 amanijoseph87