OneSignal-Website-SDK icon indicating copy to clipboard operation
OneSignal-Website-SDK copied to clipboard

Adjustments for Dev-Dev Environments

Open rgomezp opened this issue 4 months ago • 0 comments

Adjustments for Dev-Dev Environments

Summary

  • Change API port number to 3000 in dev-dev environments
  • Update build script to default to localhost for API origin in dev-dev environments

Description

This PR includes two primary updates to improve the development experience in dev-dev environments.

API Port Configuration The API port number has been modified to 3000. This aligns with the current usage in our API development environment, ensuring consistency across our development setup.

Build Script Modification We've made a key change in the build script. Now, it will automatically set the API origin to localhost when in dev-dev environments. This addresses the issue where the system would default to onesignal.com if no API origin was specified. With this update, developers can work more seamlessly, without the need to manually configure the API origin for local development.

Systems Affected

  • [x] WebSDK
  • [ ] Backend
  • [ ] Dashboard

Validation

Changes were tested in conjunction with the a running local dev server.

Checklist

  • [x] All the automated tests pass or I explained why that is not possible
  • [x] I have personally tested this on my machine or explained why that is not possible
  • [ ] I have included test coverage for these changes or explained why they are not needed
    • Changes unrelated to source code

This change is Reviewable

rgomezp avatar Feb 06 '24 20:02 rgomezp