OneSignal-Android-SDK icon indicating copy to clipboard operation
OneSignal-Android-SDK copied to clipboard

[Bug]: Logcat showing issues with cookiemanager.cc unable to set secure cookies

Open mariusbolik opened this issue 2 years ago • 5 comments

What happened?

Hello,

I am seeing this error in logcat:

[ERROR:cookie_manager.cc(135)] Strict Secure Cookie policy does not allow setting a secure cookie for http://onesignal.com/ for apps targeting >= R. Please either use the 'https:' scheme for this URL or omit the 'Secure' directive in the cookie value.

Are there some HTTP Requests not running through https?

Steps to reproduce?

I'm using Capacitor, but I think the Issue still belongs here. The problem was also mentioned in this issue: https://github.com/OneSignal/OneSignal-Android-SDK/issues/1873
I set CapacitorHttp and CapacitorCookies enabled. But I am not sure if this has an effect on the error:

const config: CapacitorConfig = {
  ...
  server: {
    androidScheme: 'https'
  },
  plugins: {
    SplashScreen: {
      launchAutoHide: false
    },
    CapacitorCookies: {
      enabled: true,
      androidCustomSchemeAllowInsecureAccess: true,
    },
    CapacitorHttp: {
      enabled: true,
    }
  }
};

What did you expect to happen?

I would expect the SDK to set cookies correctly or make requests through https.

OneSignal Android SDK version

5.0.3

Android version

13

Specific Android models

Samsung Galaxy s52 5G

Relevant log output

[ERROR:cookie_manager.cc(135)] Strict Secure Cookie policy does not allow setting a secure cookie for http://onesignal.com/ for apps targeting >= R. Please either use the 'https:' scheme for this URL or omit the 'Secure' directive in the cookie value.

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

mariusbolik avatar Nov 09 '23 13:11 mariusbolik

@mariusbolik thank you for reaching out! We are investigating and will get back to you as soon as possible.

jennantilla avatar Nov 16 '23 21:11 jennantilla

Hello, is there any update about this one?

jmonloop avatar Feb 08 '24 14:02 jmonloop

Making a note for investigating this issue that the SDK makes requests to https://api.onesignal.com/. This is probably from a webview's html.

nan-li avatar Feb 08 '24 18:02 nan-li

Hello. Any update about this one?

jmonloop avatar Feb 09 '24 13:02 jmonloop

If this helps anybody, I was able to solve it modfying the capacitor.config.ts file and putting the androidScheme into https like this

  server: {
    androidScheme: 'https',
  }

And then in the AndroidManifest, removing the clearTextTraffic attribute. Hope this helps someone.

ernes128 avatar May 08 '24 14:05 ernes128