OneSignal-Android-SDK
OneSignal-Android-SDK copied to clipboard
[question]: Friendly discussion about the stability of the 5.0.x release
How can we help?
Hey, I don't know if this is appreciated on the github, or if there is another medium for it.
Right now we (and seeing the issues, and other PM's in companies that we work with) are having big issues in the stability of Onesignal.
Some of them use capacitor with angular, capacitor with react.
The issues we run into are outdated and not detailed enough documentation (this is also the case for previous versions).
Having to read through multiple and different migration guides, because they are not all kept in sync.
Special to 5.0.x, push notifications not arriving on "older android devices" after they are pushed to the play store.
Special to 5.0.x trigger prompts for notification rights automatically pausing.
Special to 5.0.x trigger prompts not always triggering on newer devices.
Logcat showing issues with cookiemanager.cc unable to set secure cookies on http://onesignal.com (chromium)
Moving back doesn't always work either, because of the sandwich of SDK targetlevel that has been set by Google. Which would require us to make different targetted sdk builds with different library versions.
Is there any specific input or help that you require from the community?
Code of Conduct
- [X] I agree to follow this project's Code of Conduct
Maybe it'd be interesting to place these issues in this repo's board, so we can have an organized view of the confirmed issues with V5 and their statuses, if help is needed for certain issues, etc.
Good catch, We will be adding the migration from (3/4 -> 5) to a new sprint soon again (we decided to roll back after two weeks). We will document the experience and issues whwn we do that.
Thank you for this feedback--we definitely want to hear from users so that we can improve documentation and pinpoint bugs as quickly as possible.
Regarding some of the issues you describe, it would be most helpful to track each of those individually. If you are able, can you please create separate issues with more details?
Information that would be helpful:
- Android version of "older Android devices"
- Full logcat for issues such as trigger prompts and cookie issues
- Any other steps to reproduce the issues you are seeing so we can diagnose.
Again, thank you for your feedback! We really appreciate your time helping us to improve the SDK.
Regarding some of the issues you describe, it would be most helpful to track each of those individually. If you are able, can you please create separate issues with more details?
I don't think creating individual issues is the problem. I had just 4 of them being closed as duplicate in wait of some PR https://github.com/OneSignal/OneSignal-Android-SDK/pull/1886 that presumably fixes problems found 3 weeks ago https://github.com/OneSignal/OneSignal-Android-SDK/issues/1857#issuecomment-1760188701. And yes, I was going to fill more new crashes, but what's the point now.
If daily random crashes are ignored during 3 weeks and patched in the end with try/catch, it has left me with little hope of OneSignal having actual decent code. I've already had to downgrade to 4.8.6, but that one still crashes from time to time, so I wonder if the try/catch solution wasn't applied as well as 5 maybe will have (eventually).
Having seen the delays and the closing of real issues affecting apps in wait of some uncertain future has made me an advocate of removing OneSignal from any code I touch in the future.