firmware icon indicating copy to clipboard operation
firmware copied to clipboard

fix(legacy): fix ada swap issue and add common path check for chains

Open somebodyLi opened this issue 10 months ago • 1 comments

somebodyLi avatar Apr 12 '24 04:04 somebodyLi

PR Summary

  • Improved Communication for Ada Transactions In ada.c, confirmations are now explicitly sent when processing through item lists, like certificates or withdrawals, in a Cardano transaction. This makes the transaction handling more transparent and predictable.

  • Common Path Check Function Added A new function fsm_common_path_check is now implemented in fsm.c, it checks the validity of given path information such as purpose, coin type and hardening levels making our application more secure.

  • Path Validity Checks Enhanced Across multiple files Path validity checks using the new fsm_common_path_check is now used over the earlier method across multiple files and blockchain types. This common path checking method improves the code base coherence and maintainability.

  • Changes in Tron Messages In fsm_msg_tron.h, specific Tron messages now include initial responses (RESP_INIT)and check parameters (CHECK_PARAM) that'll enhance the responsiveness and security.

  • Removal of Redundant Function The nexa_path_check function, presumably superseded by fsm_common_path_check, has been removed from nexa.c and nexa.h, streamlining the codebase.

what-the-diff[bot] avatar Apr 12 '24 04:04 what-the-diff[bot]