app-monorepo icon indicating copy to clipboard operation
app-monorepo copied to clipboard

refactor: remove random querystrings from extension build artifacts

Open goosewobbler opened this issue 1 year ago • 2 comments
trafficstars

Amending the querystrings used in the extension build so that the the build artifacts have consistent hashes. This should enable the extension to be accepted by the Mozilla addons store.

https://github.com/OneKeyHQ/app-monorepo/issues/3351

goosewobbler avatar Aug 02 '24 12:08 goosewobbler

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders
Open Preview

codesandbox[bot] avatar Aug 02 '24 12:08 codesandbox[bot]

PR Summary

  • New Feature to Track Version New 'currentVersion' property added to give us the ability to keep an eye on and manage application versions.
  • Environment Specific Functionality The 'hash' property has been updated to vary its value depending on the environment. This will give us more flexibility when operating in different environments.
  • Dynamic Script Sourcing in Index The source path of the script tag has been updated. With this change, it now uses the 'currentVersion' variable. This allows the right version of the script to be loaded dynamically.

what-the-diff[bot] avatar Aug 02 '24 12:08 what-the-diff[bot]

Walkthrough

此次更改包括在 createEjsParams 函数返回的对象中添加了一个新属性 currentVersion,该属性从环境变量 process.env.VERSION 获取当前版本信息。createHtmlPlugin 函数中的 hash 属性根据环境变量 NODE_ENV 进行条件设置,只有在开发环境中才为 true。此外,HTML 模板中的脚本源 URL 从动态时间戳更新为使用 currentVersion 变量。

Changes

文件 更改摘要
development/indexHtmlParameter.js 添加 currentVersion 属性到 createEjsParams 函数返回对象,值为 process.env.VERSION
development/webpack/ext/pluginsHtml.js 修改 createHtmlPlugin 函数中的 hash 属性,根据 NODE_ENV 设置为 true(仅在开发环境中)。
packages/shared/src/web/index.html.ejs 修改脚本源 URL,从动态时间戳更新为使用 currentVersion 变量。

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Server
    participant HTMLTemplate

    Client->>Server: 请求页面
    Server->>Server: 调用 createEjsParams()
    Server->>Server: 获取 process.env.VERSION
    Server->>HTMLTemplate: 返回包含 currentVersion 的参数
    HTMLTemplate->>Client: 返回页面

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary or Summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Sep 30 '24 01:09 coderabbitai[bot]