app-monorepo icon indicating copy to clipboard operation
app-monorepo copied to clipboard

feat: enable trunk.io superlinter & git hook manager

Open dapirian opened this issue 3 years ago • 2 comments

This PR enables the trunk.io superlinter, autoformatter, & git hook manager. Trunk manages the hermetic installation and orchestration of lots of tools, as well as adds slick features on top of any code-checking or autoformatting tools.

Trunk Docs: https://docs.trunk.io/docs/get-started

  • Enabled 10 linters via Trunk (.trunk/trunk.yaml) for everything from shell scripts to GH actions definitions to javascript to svg
  • Migrated from husky to Trunk
  • Added the Trunk GitHub Action to CI which annotates inline lint results on your PR and detects which issues are new vs preexisting so a PR author only has to fix the issues they caused

This is really a jumping-off point to get started with Trunk. I'm happy to work with & discuss with the maintainers to iterate on this! Thanks

dapirian avatar Aug 10 '22 00:08 dapirian

hi @dapirian Thanks for this PR, trunk looks like a really cool tool, we'll take the time to look on it, and if it fits well with our team's engineering workflow, we'll approve and merge this PR. Thanks again.

revan-zhang avatar Aug 10 '22 09:08 revan-zhang

hi @dapirian Thanks for this PR, trunk looks like a really cool tool, we'll take the time to look on it, and if it fits well with our team's engineering workflow, we'll approve and merge this PR. Thanks again.

Great! Hit me up on slack.trunk.io if you have any questions / feedback. Thanks!

dapirian avatar Aug 10 '22 17:08 dapirian

Because github action has security-related concerns, and we are currently not considering incorporating such third-party services to increase the complexity of the system, but still thank you very much for your support to our project.

revan-zhang avatar Jun 21 '23 12:06 revan-zhang