OneFolder icon indicating copy to clipboard operation
OneFolder copied to clipboard

When writing in tags field the arrow keys moves to the next slide

Open Sturlen opened this issue 1 year ago • 1 comments

Describe the bug When writing in the tag field on a fullscreen image, pressing the left or right arrow will switch images, as well as move the cursor in the text field.

To Reproduce

  1. Open in image in fullscreen
  2. Click on the Tags field
  3. Press left or right arrow key

Expected behavior I expected only the cursor to move, not the image.

Screenshots When pressing the left and right arrow keys:

https://github.com/OneFolderApp/OneFolder/assets/43607012/765449ca-cead-4275-89a3-1fbbad77e6e1

OneFolder version

v1.0.0

Desktop OS

Windows 11

Additional context I believe this is the input field that is not stopping the propagation of the arrow keys. https://github.com/OneFolderApp/OneFolder/blob/d9a3cef51b81c2bb252e9438324aa594e0d0a1a4/src/frontend/components/TagSelector.tsx#L141

The part that triggers the slide movements https://github.com/OneFolderApp/OneFolder/blob/d9a3cef51b81c2bb252e9438324aa594e0d0a1a4/src/frontend/containers/ContentView/SlideMode/index.tsx#L104

Sturlen avatar May 21 '24 21:05 Sturlen

Thanks for all the details you provided, looks like you are right, most be a propagation issue, let me look into it

Antoine-lb avatar May 22 '24 16:05 Antoine-lb