onebusaway-ios icon indicating copy to clipboard operation
onebusaway-ios copied to clipboard

Published 20 hours ago • verified publisher icon OneBusAway

Fix: issue 625

Open RV784 opened this issue 1 year ago • 4 comments

Issue Link -> https://github.com/OneBusAway/onebusaway-ios/issues/625

Code Changes

  • Added UIScreenshotService delegate to AppDelegate
  • Adding OBAListView instance from loadView() instead of adding it as a subview in viewDidLoad()

RV784 avatar Mar 02 '24 15:03 RV784

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 02 '24 15:03 CLAassistant

@aaronbrethorst Did you get the chance to review this PR?

RV784 avatar Mar 08 '24 11:03 RV784

Hey @aaronbrethorst thanks for the feedbacks

For point 1 and 3 I'm working on this. For second point can you please elaborate on the issue you are facing? Is it with screenshot functionality or the text is not clearly visible?

RV784 avatar Mar 09 '24 15:03 RV784

@RV784 the rounded cells have black backgrounds, rendering the text illegible. Compare to the product UI where the text on this screen is clearly visible.

aaronbrethorst avatar Mar 09 '24 16:03 aaronbrethorst