Moving to Java 17

[leonardehrenfried]

The currently used version of this project is Java 8 which has been EOL for a while.

I just tried it and moving to Java 17 is actually very painless and just two lines of code.

Would you appreciate a PR for that?

The consequences of this is that you will have to use a more recent version of Java to run the code. Is this a problem?

[EmmaSimon]

I'm also trying to run this in Java 17 and it seems to work fine, except for a single test failure. Not sure if a fix for that was the code change you mentioned.

[INFO] Running org.onebusaway.gtfs_transformer.deferred.DeferredValueSupportTest                                                                                                            
[ERROR] Tests run: 4, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.019 s <<< FAILURE! - in org.onebusaway.gtfs_transformer.deferred.DeferredValueSupportTest                            
[ERROR] testResolveConverter_FieldMappingConverter(org.onebusaway.gtfs_transformer.deferred.DeferredValueSupportTest)  Time elapsed: 0.019 s  <<< ERROR!                                    
java.lang.ExceptionInInitializerError                                                                                                                                                       
        at org.onebusaway.gtfs_transformer.deferred.DeferredValueSupportTest.testResolveConverter_FieldMappingConverter(DeferredValueSupportTest.java:79)                                   
Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError accessible: module java.base does not "opens java.lang" to unnamed module @7d70d1b1                                                           
        at org.onebusaway.gtfs_transformer.deferred.DeferredValueSupportTest.testResolveConverter_FieldMappingConverter(DeferredValueSupportTest.java:79)

[leonardehrenfried]

I had a video meeting with @sheldonabrown a few months ago where he said that he is quite conservative about upgrading Java versions so for now he has decided to migrate to Java 11. At the time of writing this it had been Java 8.

[sheldonabrown]

Thanks Leonard -- that's exactly my take.

However the test in question deals with some introspection that will need to be solved at some point. I'd happily entertain PRs to fix that.

On Wed, Apr 26, 2023 at 10:49 AM Leonard Ehrenfried < @.***> wrote:

I had a video meeting with @sheldonabrown https://github.com/sheldonabrown a few months ago where he said that he is quite conservative about upgrading Java versions so for now he has decided to migrate to Java 11. At the time of writing this it had been Java 8.

— Reply to this email directly, view it on GitHub https://github.com/OneBusAway/onebusaway-gtfs-modules/issues/208#issuecomment-1523554381, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAHUSHL4D6XBWT6JZUC2ASTXDEYZNANCNFSM6AAAAAAS45ZIAM . You are receiving this because you were mentioned.Message ID: @.***>