onebusaway-application-modules icon indicating copy to clipboard operation
onebusaway-application-modules copied to clipboard

OBA fails with GTFS-rt feed from another OBA server

Open sirott opened this issue 9 years ago • 3 comments

I've had problems with the GTFS-rt from the King County OBA server sending empty arrival info; something like:

stop_time_update{ arrival { } departure { time: 1442424141 } }

OBA throws an IllegalStateException when this happens. It should be modified to handle this gracefully and use the departure time instead (or the arrival time if the departure time is missing).

sirott avatar Nov 26 '15 02:11 sirott

Can you try the develop branch and see if this still occurs there?

As part of the per-stop prediction work we added support for arrival and departure times, which might fix this.

barbeau avatar Nov 26 '15 14:11 barbeau

Not seeing the changes that would fix this; the problem is in GtfsRealtimeTripLibrary.computeArrivalTime where an exception is thrown which is inconsistent with returning -1 for the other cases where the arrival time info is missing.

sirott avatar Nov 26 '15 18:11 sirott

@sirott do you have a pull request to fix this? I'd be happy to review it if so...

sheldonabrown avatar Jun 13 '16 14:06 sheldonabrown