onebusaway-android icon indicating copy to clipboard operation
onebusaway-android copied to clipboard

Dependency on Google Service

Open hariettem opened this issue 10 months ago • 8 comments

Curious what the lift for this would be? Love the app being open source but it's dependent on Google ecosystem. Making it unsuitable for degoogle phones.

hariettem avatar Jan 30 '25 00:01 hariettem

No idea, but we welcome PRs

aaronbrethorst avatar Jan 30 '25 02:01 aaronbrethorst

Do you mean supporting Huawei devices for example without depending on Google play services ?

amrhossamdev avatar Jan 30 '25 09:01 amrhossamdev

@aaronbrethorst @amrhossamdev We can consume another open-source library for maps like open street maps for devices that don't support Google play services.

CyberFranky05 avatar Feb 08 '25 18:02 CyberFranky05

I would love to use this app on my degoogled phone! How can I pitch in for rebasing to consume a non-Google maps api?

andrewpking avatar Feb 09 '25 19:02 andrewpking

FWIW, here's an example of using Gradle build flavors to support two separate builds of an app, one using Google Maps and one using OSMDroid:

  • https://github.com/barbeau/gpstest/blob/master/GPSTest/build.gradle

The catch is that the last time I checked, OSMDroid doesn't have the same API as Google maps. So you're basically talking about reimplementing all of the code that interacts directly with the Maps API. I did that in the above project so two different map Fragments are implemented, one for each build flavor.

  • https://github.com/barbeau/gpstest/blob/master/GPSTest/src/google/java/com/android/gpstest/ui/MapFragment.kt
  • https://github.com/barbeau/gpstest/blob/master/GPSTest/src/osmdroid/java/com/android/gpstest/ui/MapFragment.kt

There might be a better way to do it today- maybe there's a new library wrapper for osm tiles that matches the Google Maps API.

barbeau avatar Feb 09 '25 21:02 barbeau

@aaronbrethorst @amrhossamdev i would like to work on this issue please assign it to me

CyberFranky05 avatar Feb 15 '25 16:02 CyberFranky05

Feel free to write a technical plan for that. @MRELEC1R0N

amrhossamdev avatar Mar 13 '25 03:03 amrhossamdev

@amrhossamdev Give me some time to analyse the code base more deeply and what sections of Google API are consumed and what open source alternatives we have here

CyberFranky05 avatar Mar 16 '25 20:03 CyberFranky05