onebusaway-android icon indicating copy to clipboard operation
onebusaway-android copied to clipboard
verified publisher icon OneBusAway

Upgrade Target SDK to 34 and fix foreground services compatibility with Android 14

Open amrhossamdev opened this issue 1 year ago • 3 comments

Releted to #1228 & #1230 and #1231

  • [x] Apply the AndroidStyle.xml style template to your code in Android Studio.

  • [x] Run the unit tests with gradlew connectedObaGoogleDebugAndroidTest to make sure you didn't break anything

  • [x] If you have multiple commits please combine them into one commit by squashing them for the initial submission of the pull request. When addressing comments on a pull request, please push a new commit per comment when possible (reviewers will squash and merge using GitHub merge tool)

amrhossamdev avatar Aug 28 '24 18:08 amrhossamdev

@amrhossamdev is this ready for review?

aaronbrethorst avatar Aug 28 '24 22:08 aaronbrethorst

@amrhossamdev is this ready for review?

Not yet, I will finish #1231 and I will request a review

amrhossamdev avatar Aug 28 '24 23:08 amrhossamdev

Ready for review @aaronbrethorst

amrhossamdev avatar Aug 29 '24 12:08 amrhossamdev