onebusaway-android icon indicating copy to clipboard operation
onebusaway-android copied to clipboard

Changing trip options causes a blank interface in some cases

Open devinbraun opened this issue 5 years ago • 3 comments

Summary:

Blank interface is shown when changing trip options from a successful trip plan to an unsuccessful trip plan.

Steps to reproduce:

Create a valid trip plan, then change the trip options making the trip invalid or unsuccessful, such as from TRANSIT to Rail only where Rail isn't available and OBA returns a blank screen and the interface elements are frozen/unusable

Expected behavior:

Provide a message that the trip plan is invalid as it would in any other instance when getting an invalid trip on the first try and then return the user to the form to make changes.

Device and Android version:

App Version: 2.7.0 Model: Pixel 2 OS Version: 10 / 29

Screenshots:

OBA Trip Planner Blank Screen

devinbraun avatar Apr 22 '20 22:04 devinbraun

@devinbraun Could provide an exact input for origin and destination where you're seeing this? Also, could you confirm you're on OBA Android v2.7.0 (via Settings->About)?

I can't seem to reproduce this on a Samsung Galaxy S8+ with Android 9 w/ v2.7.0.

In Tampa and San Diego, if I successfully plan a "Transit only" trip, and then switch to "Rail only", I get the normal "Planning not possible" UI. Here's a San Diego example:

image

barbeau avatar Apr 23 '20 15:04 barbeau

I'm on v2.7.0 (117)

I did a little more testing and at first, I also got the regular "planning not possible" message, but then when I tried again, it didn't work. What I found was that if the trip planning inputs where "hidden" when I changed trip preferences, I see the bug. If they are showing when I changed the inputs, I didn't experience the bug. The inputs are "hidden" when a successful trip plan shows up, and I have to pull them down to show them.

oba trip plan no trip inputs showing OBA trip plan with trip inputs showing

devinbraun avatar Apr 23 '20 16:04 devinbraun

@devinbraun Ah, ok, thanks! Yes, I can reproduce this now. Thanks for the additional info, I'll take a look.

barbeau avatar Apr 23 '20 16:04 barbeau