One icon indicating copy to clipboard operation
One copied to clipboard

🧪 Current pre-commit requirements and enhancements 🧪

Open jbampton opened this issue 1 year ago • 3 comments

With pre-commit we run:

  • clang-format
  • hadolint-docker
  • shellcheck

That means we require both clang-format and the docker executable to be pre-installed to be able to run:

pre-commit run --all-files successfully.

We also need to install pre-commit itself and I am thinking we should do this with pip and create a Make target.

That means Python itself is required too.

Which leads to a full Docker container perhaps

Are there any other requirements ?

jbampton avatar Oct 03 '23 17:10 jbampton

refs #447

jbampton avatar Oct 03 '23 17:10 jbampton

please assign me i want to work on it

btwshivam avatar Oct 04 '23 15:10 btwshivam

Hi my friend, welcome to the community and team. Best wishes -- MAX

BaseMax avatar Oct 04 '23 19:10 BaseMax