zedux icon indicating copy to clipboard operation
zedux copied to clipboard

feat(core)!: remove hierarchy config

Open bowheart opened this issue 10 months ago • 29 comments

Description

Remove the Store class's hierarchyConfig static property. This is a breaking change, but likely won't affect any Zedux users since we left this feature undocumented, intending to remove it.

The hierarchy config allowed stores to use different hierarchical data structures besides the default JS object. Zedux would then be able to intelligently merge nested reducers and stores together in e.g. an Immutable Map. Its setStateDeep would also use the hierarchyConfig

In practice, this is never used. Reducers are almost never used in Zedux and there's no point to using Immutable JS to wrap a simple child store mapping. It's easy to create an ImmutableJS zero-config store by setting that as the value and using setState on that value directly, ignoring setStateDeep.

If deeper functionality is needed, users are still able to extend the Store class (another undocumented feature) and modify absolutely everything. While that's more involved, it's probably necessary anyway - as it is, hierarchyConfig doesn't work intuitively for nested stores. Expanding Zedux's current hierarchyConfig model to cover all use cases would not be simple, would add codebase bloat, and would still never be used. Most importantly it would be redundant - since extending the Store class is already possible, we should make it the only way to add rarely-needed functionality like this.

bowheart avatar Apr 28 '24 11:04 bowheart

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 15 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 16 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 17 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 18 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 19 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 20 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 21 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 22 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 23 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 24 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 25 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 26 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 27 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 28 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 29 '24 05:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 29 '24 19:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 29 '24 19:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 30 '24 19:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar May 31 '24 19:05 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 01 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 02 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 03 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 04 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 05 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 06 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 07 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 08 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 09 '24 19:06 trumid-prow

@bowheart: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

trumid-prow avatar Jun 10 '24 19:06 trumid-prow