Crash on unhandled DirectoryNotFoundException using OmniSharpStartServerSolution from gvim

[baskus]

I manually start the server from gvim using OmniSharpStartServerSolution under Windows 8.1. I accidentally enter an invalid path. The server starts in a separate command window but then crashes in Program.cs because of an unhandled DirectoryNotFoundException in the StartServer method.

I installed OmniSharp by cloning the git rep into my bundle folder in vimfiles as instructed here https://github.com/nosami/Omnisharp. When i run git log inside the OmniSharp/server dir the newest commit is eda5165c2a91e095d3b7af4682a41f39bb6f4859.

[nosami]

How do you think it should behave? Just log a message and exit?

Btw, you should probably get vim-dispatch running and let it automatically start OmniSharpServer for you.

[baskus]

I have vim-dispatch and it does try to start the server. However, the setup is currently that the solution is in another folder and OmniSharpServer can't find it automatically so I just get an error message after vim-dispatch launches the server.

In this particular case of an invalid path I would much prefer it to tell me somehow and exit cleanly. As it is now I get a dialog saying it crashed which isn't very pretty. Optimally I would get an error message inside of gvim.

[nosami]

I'm not sure if it's possible for me to get a message back to vim when the server didn't start correctly due to vim-dispatch's async nature. Vim isn't designed for async code :)

The server shouldn't crash though... that can definitely be fixed. Want to put a pull request in? :) If not, I'll do it when I get chance.

[baskus]

Unfortunately I have very little time to spare at the moment, sorry.