omnisharp-server icon indicating copy to clipboard operation
omnisharp-server copied to clipboard

GetTestContextHandler does not cater for .exe assemblies

Open egarson opened this issue 10 years ago • 3 comments

Hello

The AssemblyName generated by https://github.com/OmniSharp/omnisharp-server/blob/master/OmniSharp/TestContextInformation/GetTestContextHandler.cs#L67 assumes the assembly is a .dll, and thus doesn't work for .exe.

I'm using omnisharp-emacs, and the net result of the above is that I can't run unit tests in .exe assemblies.

Is there some good reason that .dll is hardcoded?

Thank you

egarson avatar Feb 04 '15 21:02 egarson

It doesn't need to be. Do you want to submit a PR?

nosami avatar Feb 04 '15 22:02 nosami

Well in that case it's the right thing to do... I'll take a look into setting this project up, running tests and such before I verbally commit ;-)

Thank you

egarson avatar Feb 05 '15 15:02 egarson

Cheers! You'll probably need to look at the project files to determine the output path I would imagine.

On Thu, Feb 5, 2015 at 3:27 PM, Edward Garson [email protected] wrote:

Well in that case it's the right thing to do... I'll take a look into setting this project up, running tests and such before I verbally commit ;-)

Thank you

— Reply to this email directly or view it on GitHub https://github.com/OmniSharp/omnisharp-server/issues/177#issuecomment-73064616 .

nosami avatar Feb 05 '15 15:02 nosami