omnisharp-node-client icon indicating copy to clipboard operation
omnisharp-node-client copied to clipboard

Language Server implementation doesn't set range end for textDocument/definition

Open mickaelistria opened this issue 8 years ago • 2 comments

I'm invoking textDocument/definition. The returned range starts correctly, however the end isn't set. The expectation would be in this case that the range gets to the last character of the variable name. The issue seems to be that the underlying /gotodefinition operation from the server doesn't return and end position nor a length.

mickaelistria avatar Jul 27 '16 14:07 mickaelistria

Right now the server doesn't have any the span of the definition (something we will have to add eventually).

Are you not getting any end position back? Or is it just the same as the start position? (Right now it should be the same position for both).

To get the proper end position we'll have to add that to the server resposne.

david-driscoll avatar Jul 27 '16 16:07 david-driscoll

Are you not getting any end position back?

No end position at all (which is better than a wrong end position)

mickaelistria avatar Jul 27 '16 17:07 mickaelistria