omnisharp-node-client icon indicating copy to clipboard operation
omnisharp-node-client copied to clipboard

differentiate between dependencies and dev-dependencies for the sake of size

Open jrieken opened this issue 9 years ago • 7 comments

Installing omnisharp-client consumes 96MB on disk while OmniSharp itself just the half (46MB). tsd and typescript, which seem like dev dependencies, sum up to 26MB. So some low hanging fruit here...

jrieken avatar Aug 26 '15 16:08 jrieken

btw - I'd like to sign up for this.

jrieken avatar Aug 26 '15 16:08 jrieken

Also it seems that RX can be slimmer. I see all files in dist/ being foo.[js|map|min.js]...

jrieken avatar Aug 26 '15 16:08 jrieken

Sounds good to me!

I do know that as part of the install process we run the typescript task through the post-install and pre-publish commands for npm. So we might have to fiddle with the build to get the proper JS output stashed to npm, without requiring the .ts files to be published (or publish them, but don't try to regenerate them).

Depend on what happens above we might also need to generate the declarations for local developers so they get the type information (today atom just references the ts files through the node_modules directory).

PS: Does this mean VSCode might be evaluating using the same dep as atom? :grinning:

If you want to try and pair sometime to figure what we need to do out, I can make time for sure.

david-driscoll avatar Aug 26 '15 16:08 david-driscoll

Rx also has https://github.com/Reactive-Extensions/RxJS-Modular but it hasn't been updated in a few months, maybe @mattpodwysocki might have some input.

Worst case on the Rx front we could take a local dependency on it, and just copy the raw file from github into the release based on whatever release we're looking at, and then remove it as a direct dependency.

david-driscoll avatar Aug 26 '15 16:08 david-driscoll

oh there's also https://github.com/Reactive-Extensions/RxJS-CLI maybe that could be useful.

david-driscoll avatar Aug 26 '15 16:08 david-driscoll

I've got my changes @ https://github.com/OmniSharp/omnisharp-node-client/tree/diet-publish

@jrieken let me know if you want me to push them onto diet and we can merge it.

david-driscoll avatar Sep 01 '15 16:09 david-driscoll

:+1:

jrieken avatar Sep 02 '15 07:09 jrieken