omnisharp-emacs icon indicating copy to clipboard operation
omnisharp-emacs copied to clipboard

Published 20 hours ago • verified publisher icon OmniSharp

[Roslyn] Add support for constructor/method signature intellisense

Open jtbm37 opened this issue 9 years ago • 10 comments

Roslyn has support for it here and has tests.

We just need to show the signature when typing (.

Optionally user can call the function when point is inside parentheses.

jtbm37 avatar May 07 '16 21:05 jtbm37

We should also probably show it when typing a , inside parentheses but also when there is only one opening bracket.

jtbm37 avatar May 07 '16 21:05 jtbm37

:+1: What do you think, would eldoc suffice? We display current type information with eldoc.

On the other hand, for example lispy goes the extra step and displays stuff like this in an overlay:

overlay

mikavilpas avatar May 09 '16 18:05 mikavilpas

I am thinking we should use company so we can expand the selection like a snippet and then filling in each parameters by tabbing through. We could even use company quickhelp to display extra information.

I am not sure how eldoc would display 5 constructor/method overloads.

jtbm37 avatar May 10 '16 22:05 jtbm37

Ah I see what you mean. Eldoc is clearly out of the question. I haven't really looked at the server api yet.

2016-05-11 1:12 GMT+03:00 jtbm37 [email protected]:

I am thinking we should use company so we can expand the selection like a snippet and then filling in each parameters by tabbing through. We could even use company quickhelp https://github.com/expez/company-quickhelp to display extra information.

I am not sure how eldoc would display 5 constructor/method overloads.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/OmniSharp/omnisharp-emacs/issues/224#issuecomment-218307662

mikavilpas avatar May 11 '16 08:05 mikavilpas

Roslyn has now a new completion API available. This is very exciting.

It needs to be implemented in omnisharp-roslyn. When it is, we could have new completion capabilities like in object initializer which we previously did not.

jtbm37 avatar May 12 '16 10:05 jtbm37

This is exciting! Let's keep an eye on that. I wonder if the completion API will change, or if it's just going to be an internal change with no visible changes to the outside.

mikavilpas avatar May 12 '16 11:05 mikavilpas

How is that looking ? selection_004

jtbm37 avatar May 12 '16 23:05 jtbm37

looking great!

mikavilpas avatar May 16 '16 05:05 mikavilpas

@jtbm37 Completion API has now been merged into omnisharp-roslyn: https://github.com/OmniSharp/omnisharp-roslyn/pull/583 :)

willl avatar Jun 14 '16 23:06 willl

@willl Thanks. I will surely be testing that fairly soon. :+1:

jtbm37 avatar Jun 15 '16 13:06 jtbm37