csharp-language-server-protocol icon indicating copy to clipboard operation
csharp-language-server-protocol copied to clipboard

Published 20 hours ago • verified publisher icon OmniSharp

chore(deps): update rocket surgery other

Open renovate[bot] opened this issue 2 years ago • 3 comments

This PR contains the following updates:

Package Change Age Adoption Passing Confidence Type Update
Rocket.Surgery.MSBuild.CI (source) 1.1.5 -> 1.2.1 age adoption passing confidence nuget minor
Rocket.Surgery.MSBuild.SourceLink (source) 1.1.5 -> 1.2.1 age adoption passing confidence nuget minor
Rocket.Surgery.Nuke (source) 1.7.4 -> 1.8.36 age adoption passing confidence nuget minor
RocketSurgeonsGuild/actions v0.3.3 -> v0.3.12 age adoption passing confidence action patch

Release Notes

RocketSurgeonsGuild/MSBuild.Targets (Rocket.Surgery.MSBuild.CI)

v1.2.0

What's Changed
:rocket: Features and :fire: Enhancements
Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/MSBuild.Targets/compare/v1.1.5...v1.1.6

RocketSurgeonsGuild/Nuke (Rocket.Surgery.Nuke)

v1.8.36

What's Changed

:lady_beetle: Bugs and Security Fixes
Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.35...v1.8.36

v1.8.35

What's Changed

:lady_beetle: Bugs and Security Fixes
Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.34...v1.8.35

v1.8.34

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.33...v1.8.34

v1.8.33

What's Changed

Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.32...v1.8.33

v1.8.32

What's Changed

Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.31...v1.8.32

v1.8.31

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.30...v1.8.31

v1.8.28

What's Changed

Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.27...v1.8.28

v1.8.26

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.25...v1.8.26

v1.8.25

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.24...v1.8.25

v1.8.24

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.23...v1.8.24

v1.8.23

What's Changed

Public Dependencies
Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.22...v1.8.23

v1.8.22

What's Changed

Other Items

Full Changelog: https://github.com/RocketSurgeonsGuild/Nuke/compare/v1.8.21...v1.8.22

v1.8.21

What's Changed

Other Items
  • ensure hus

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.

  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Nov 20 '23 21:11 renovate[bot]

The "default.runsettings could not be found" issue is now fixed. Unfortunately, the build is also blocked by some NRE for windows and macos environments.

Object reference not set to an instance of an object.

As I do not reproduce the issue locally, without any additional clue(s), like a call stack, it will be difficult to identify then fix the issue here. @JoeRobich Is there a way to get a call stack for this exception?

manandre avatar Jun 16 '24 20:06 manandre

I have managed to add some verbose logging, what reveals the NRE call stack:

System.NullReferenceException: Object reference not set to an instance of an object.
   at Rocket.Surgery.Nuke.ContinuousIntegration.PrintBuildVersionAttribute.OnBuildInitialized(IReadOnlyCollection`1 executableTargets, IReadOnlyCollection`1 executionPlan) in /_/src/Nuke/ContinuousIntegration/PrintBuildVersionAttribute.cs:line 23
   at Nuke.Common.Utilities.Collections.EnumerableExtensions.ForEach[T](IEnumerable`1 enumerable, Action`1 action) in /_/source/Nuke.Utilities/Collections/Enumerable.ForEach.cs:line 20
   at Nuke.Common.NukeBuild.ExecuteExtension[TExtension](Expression`1 action)
   at Nuke.Common.Execution.BuildManager.Execute[T](Expression`1[] defaultTargetExpressions)

The history of the PrintBuildVersionAttribute class shows that a nullability check has been (intentionally?) removed. For an unknown reason, the gitversion is not correctly computed on windows and macos platforms:

Building version null of LSP (Release) using version 7.0.6 of Nuke

Should we:

  • analyze why the gitversion is not correctly computed?
  • open an issue on the RSG/Nuke repo to tolerate null gitversion?

@JoeRobich What do you recommend?

manandre avatar Jun 16 '24 21:06 manandre

The issue with GitVersion.Tool may be related to https://github.com/nuke-build/nuke/issues/1344 I propose to wait for a fix before investigating further.

manandre avatar Jun 18 '24 22:06 manandre

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

renovate[bot] avatar Jan 31 '25 08:01 renovate[bot]