Kulture icon indicating copy to clipboard operation
Kulture copied to clipboard

Merge Kulture and OmniSharpSublime

Open jchannon opened this issue 9 years ago • 10 comments

I think in time we should move this into OmniSharpSublime.

My current thought is OmniSharpSublime will need to detect whether its working on a vNext project or a traditional solution project ie. it searches for project.json

Based on the search this will enable/disable certain features of the plugin suitable for traditional/vNext projects.

Anyway thats my brain dump but just thought I'd tentatively open this issue for discussion.

jchannon avatar Dec 02 '14 16:12 jchannon

I was thinking yesterday, that the server should return the list of 'k' commands to run from the project.json file.

nosami avatar Dec 02 '14 16:12 nosami

We spoke about this before and I said at the time that not everyone who uses omnisharp would use Kulture.... but it seems like a small change to add to the server and we're gonna need it for the other editors.

nosami avatar Dec 02 '14 16:12 nosami

Sounds good, I'm all for it. I think that is the best course of action.

sayedihashimi avatar Dec 02 '14 16:12 sayedihashimi

What do you guys think are the next steps for merging? Would now be a good time to have another call?

sayedihashimi avatar Dec 18 '14 07:12 sayedihashimi

Might want to speak to @davidfowl about this too. https://github.com/OmniSharp/omnisharp-roslyn/issues/22

nosami avatar Dec 18 '14 10:12 nosami

Hey there, do you already have somewhere an exhaustive list of the features to merge into OmniSharpSublime ? I will have a look at the source code for now but I think I can spend time on this.

cubitouch avatar Feb 12 '15 12:02 cubitouch

I don't have a list maybe @sayedihashimi does. There is a PR here that needs fixing on the server which will expose the k commands for the project which editors can use https://github.com/OmniSharp/omnisharp-roslyn/pull/67

jchannon avatar Feb 12 '15 13:02 jchannon

I think the main things that we need are exposing the k commands and project.json intellisense. project.json intellisense should be done on the server I think to make it easier for the other editors to integrate.

nosami avatar Feb 12 '15 13:02 nosami

@cubitouch We hang out in https://jabbr.net/#/rooms/omnisharp if you want to drop by and chat :)

nosami avatar Feb 12 '15 13:02 nosami

Ok, will try to have a look at this PR. @nosami I can not come now, but I will try in few hours :)

cubitouch avatar Feb 12 '15 13:02 cubitouch