Omkar kulkarni comments

Results 35 comments of


                                            Omkar kulkarni

Add Golang linting in CI and remove unreachable code from the repo

Hi @akshay196 I want to work on this issue!

Add Golang linting in CI and remove unreachable code from the repo

- After running `golangci-lint run --fix` showing lint errors ![image](https://github.com/paralus/paralus/assets/88308267/c35503b6-94fd-43ae-8bc9-3d66ecb0fcf5) - But after this command `golangci-lint run --enable-all --fix` resolving lint errors automatically? Or we have to do it manually?...

Add Golang linting in CI and remove unreachable code from the repo

@akshay196 Sure. I'll raise a PR soon. Also, I want to ask if we create the `lint.yaml` file separately under `.github/workflows`, or in `go.yaml` we can add the lint job?

Add Golang linting in CI and remove unreachable code from the repo

Cool. Thanks @akshay196

added lint checker in CI and fixes lint errors

Hey @akshay196 So sorry for the late reply as I was a little busy with my college stuff. I am not working on this issue right now.