qtjambi icon indicating copy to clipboard operation
qtjambi copied to clipboard

Wrong minial version for QWebEngineFileSystemAccessRequest?

Open mchistovib opened this issue 3 years ago • 3 comments

Describe the bug Because of QWebEngineFileSystemAccessRequest marked as since 6.2 in once place, while it is since 6.4 in all othjer places, I can't build current jambi build.

To Reproduce Steps to reproduce the behavior:

  1. Try compile
  2. Build always fails because of QWebEngineFileSystemAccessRequest not available in qt 6.2.5

Expected behavior QWebEngineFileSystemAccessRequest shouldn't be used for 6.2 jambi

Screenshots If applicable, add screenshots to help explain your problem.

System (please complete the following information):

  • OS: Windows
  • Java version 11
  • QtJambi version 6.2.7
  • Qt version 6.2.5

Additional context See file \generator\typesystem\xml\typesystem_webenginecore-common.xml There check on QWebEngineFileSystemAccessRequest usages. It's marked as 6.4 almost everywhere: <value-type name="QWebEngineFileSystemAccessRequest" since="6.4"> However in once place it is included for 6.2 method:

<object-type name="QWebEnginePage" since="6.2.0">
        <extra-includes>
            <include file-name="QtWebEngineCore/QWebEngineFileSystemAccessRequest" location="global"/>
            <include file-name="qtjambi/qtjambi_repository.h" location="global"/>
            <include file-name="qtjambi/qtjambi_jobjectwrapper.h" location="global"/>
        </extra-includes>

I checked and there is no QWebEngineFileSystemAccessRequest in C:\Qt\6.2.5\msvc2019_64\include\QtWebEngineCore

mchistovib avatar Sep 14 '22 20:09 mchistovib

after removing <include file-name="QtWebEngineCore/QWebEngineFileSystemAccessRequest" location="global"/> line locally I now have this error:

QtCore\6.2.5 -IC:\Qt\6.2.5\msvc2019_64\include\QtCore\6.2.5\QtCore -IC:\Qt\6.2.5\msvc2019_64\include -IC:\Qt\6.2.5\msvc2019_64\include\QtCore -Idebug -IC:\Qt\6.2.5\msvc2019_64\mkspecs\win32-msvc -Fodebug\ @C:\Users\max\AppData\Local\Temp\metainfo.obj.72764.297.jom
     [make] metainfo.cpp
     [make]     link /NOLOGO /DYNAMICBASE /NXCOMPAT /DEBUG /DLL /SUBSYSTEM:WINDOWS /VERSION:6.2 /MANIFEST:embed /OUT:..\lib\QtJambiCored6.dll @C:\Users\max\AppData\Local\Temp\QtJambiCored6.dll.72764.656.jom
     [make]     copy /y ..\lib\QtJambiCored6.dll ..\bin
     [make] Скопировано файлов:         1.
     [make]     copy /y ..\lib\QtJambiCore6.dll ..\bin
     [make] Скопировано файлов:         1.

javac.excludes:

java.build.qtjambi:

build:

BUILD FAILED
C:\Users\max\source\repos\qtjambi\antfiles\java.xml:24: The following error occurred while executing this line:
C:\Users\max\source\repos\qtjambi\src\java\qtjambi-modules\modules.xml:4: Problem: failed to create task or type if
Cause: The name is undefined.
Action: Check the spelling.
Action: Check that any custom tasks/types have been declared.
Action: Check that any <presetdef>/<macrodef> declarations have taken place.

[of course I did not modify any other files to cause this error] Upd I had to install http://ant-contrib.sourceforge.net/#install to make it work. Don't know how it managed to work before

mchistovib avatar Sep 14 '22 21:09 mchistovib

Maybe you should delete extjars directory and let it download ant-contrib.jar again. The line needs an addition:

<include file-name="QtWebEngineCore/QWebEngineFileSystemAccessRequest" location="global" since="6.4.0"/>

omix avatar Sep 22 '22 13:09 omix

I did delete, rebuiold, etc, nothing worked. But once I commented out this line, it builds just fine

mchistovib avatar Sep 26 '22 11:09 mchistovib