yii2-multilingual-behavior icon indicating copy to clipboard operation
yii2-multilingual-behavior copied to clipboard

incorrect current language set in Behavior if use from extension

Open igorveremsky opened this issue 6 years ago • 0 comments

I have an extension with MultilingualActiveRecord.php that extends from ActiveRecord.php has additional multilingual attributes sets and add your behavior to behaviors(). But when i extend model in my application from it i get incorrect values for multilingual attributes for current language, because MultilingualUrlManager.php set application language after loading MultilingualActiveRecord.php and $currentLanguage at MultilingualBehavior set from language parameter in application config instead of MultilingualUrlManager.php logic for get current language. So, i think method https://github.com/OmgDef/yii2-multilingual-behavior/blob/9589c9dfdf5f082b29a0b24f48bdc68c3c23c27f/src/MultilingualBehavior.php#L518 need be like

/**
     * @return mixed|string
     */
    public function getCurrentLanguage()
    {
        return Yii::$app->language;
    }

Also in general think $currentLanguage not needed in behavior because global yii application has language param.

igorveremsky avatar Oct 30 '18 20:10 igorveremsky