Ombi icon indicating copy to clipboard operation
Ombi copied to clipboard

Clicking request, approve request, or reject request too quickly results in duplicate email notifications

Open douglasparker opened this issue 4 years ago • 1 comments

Describe the bug It seems that there is a bug where duplicate email notifications are sent when clicking more than once to submit requests and possibly when approving / rejecting requests.

To Reproduce

  1. Login to Ombi as a user that doesn't automatically approve requests.
  2. Search for content to request.
  3. Click the request button several times.
  4. Login to Ombi as a user that can approve requests.
  5. Go to the request list, click options, and then click approve request several times.
  6. Confirm that duplicate email notifications are sent.

Expected behavior

  • Multiple clicks should not process input after the first submission.
  • The prompt that comes up when clicking options should close immediately after clicking approve request.

Screenshots n/a

Logs n/a

Desktop:

  • Windows 10 Pro V1909 / Build: 18363.720
  • Chrome V80.0.3987.149

Server:

  • Ubuntu 18.04.4 LTS
  • Ombi V4.0.234.0
  • Sonarr V2.0.0.5344
  • Mono V6.8.0.105
  • Plex Media Server V4.22.2

Additional context This bug was found in Ombi V4. This may be a notification wide issue, not just for email notifications. This may be a bug that appears in more places throughout Ombi V4 while interacting with the UI.

douglasparker avatar Mar 23 '20 18:03 douglasparker

Hi!
Thanks for the issue report. Before a real human comes by, please make sure you used our bug report format.
Have you looked at the wiki yet? https://github.com/tidusjar/ombi/wiki/
Before posting make sure you also read our FAQ.
Make the title describe your issue. Having 'not working' or 'I get this bug' for 100 issues, isn't really helpful.
If we need more information or there is some progress we tag the issue or update the tag and keep you updated.
Thanks!
Ombi Bot.

ombi-bot avatar Mar 23 '20 18:03 ombi-bot