Omar Tawfik

Results 70 comments of Omar Tawfik

@alecthomas Thanks for working on https://github.com/cashapp/hermit/pull/343 .. Can we add a code example to the docs ([this page](https://cashapp.github.io/hermit/usage/config/)) of a `sources` entry using a URL + a specific commit SHA?...

> Want to file an issue? Created these two issues, and added more details/comments to them: * https://github.com/cashapp/hermit/issues/344 * https://github.com/cashapp/hermit/issues/345

I have a suspicion it is related to checks like these: https://github.com/NomicFoundation/hardhat-vscode/blob/9cfb24bb204bdab9b6f58f7598467205cc401887/server/src/services/validation/DiagnosticConverter.ts#L76-L82 https://github.com/NomicFoundation/hardhat-vscode/blob/9cfb24bb204bdab9b6f58f7598467205cc401887/server/src/compilerDiagnostics/conversions/constrainByRegex.ts#L10-L12 I wonder if we should treat such locations as `[0,0]` instead of throwing/failing? Looks to me like...

@jonasbb ahh, they decided on yaml instead of json :( I don't have time to update the extension right now, but contributions are welcomed :) I can provide pointers if...

cc @nrc Closes #43 Closes #62

I implemented the feature in #65 (first time contributor to this crate). Please let me know what you think.

cc @tcort any thoughts about how involving the fix is? I imagine it is a simple change, but probably involves a few different packages.

@AntonyBlakey I filled the basic fields for now (I should find a way to automate this next). Please feel free to edit as needed.

I really think we should make it required everywhere. From an API perspective, if i'm iterating on children, or even filtering/inspecting a specific child, I should be able to read/know...

Another idea: we might not need a side channel after all, if we can derive this info from existing node kinds (example below). We would need to use #808 to...