Omar Basem

Results 87 comments of Omar Basem

> hey @OmarBasem sorry for late response, could you please rebase, and try `make test` locally, seems like tests failed @flexsurfer As mentioned above, I have already tried rebasing 3...

> hey @OmarBasem you need to update status go version I see all checks have passed. It is the same version v0.107.1.

> but I suppose this PR depends on [status-im/status-go#2771](https://github.com/status-im/status-go/pull/2771) ? so version from PR should be used? @flexsurfer That's what I had when I first made the PR, but it...

@flexsurfer I am not sure if I still need to have it pointing to a specific status-go commit?

> i guess your changes already in latest go version so you could just use latest version @flexsurfer is `status-mobile` develop branch using latest `status-go` develop branch?

> i think yes Apparently not. The develop branch is currently using an older commit. I updated it to the corresponding commit.

> hey @OmarBasem please fix `make lint` , and also one question, is this PR can be tested in the new UI ? @flexsurfer What do you mean can be...

> but you need to bump version in status-go, so we can use it Yes I already did