copybara-action icon indicating copy to clipboard operation
copybara-action copied to clipboard

Add `destination_files` to push to not overwrite certain files in Destination repo

Open xcskier56 opened this issue 3 years ago • 3 comments

:bulb: Feature proposal

Use-cases

In our destination repo, we want to have certain files that are only contained in it and not overwritten when pushed to. Specifically we have different github actions in the destination repo vs the SoT repo and don't want them overwritten.

Attempted solutions

I have already added pr_exludes to the github action config and it does not seem to be working. The other solution would be to just use our completely custom copy.bara.sky file, but that removes a lot of the magic of this code that is very nice.

Proposal

add destination_files = glob(PR_INCLUDE, exclude = PR_EXCLUDE), to the push workflow

xcskier56 avatar Dec 27 '21 20:12 xcskier56

hey @xcskier56 any plans of merging this PR?

zubeyiro avatar Oct 20 '22 10:10 zubeyiro

Wow, I totally forgot that this PR was open. We aren't using this workflow anymore so I don't need it, but happy to make any changes to the PR that you'd like me to

xcskier56 avatar Nov 15 '22 23:11 xcskier56

PR is fine, Ive forked this repo and applied PR already: https://github.com/mailchain/copybara-action

zubeyiro avatar Nov 16 '22 20:11 zubeyiro