Olivier Zalmanski

Results 26 comments of Olivier Zalmanski

Ok @robertklep, but still I think it should be `state2value(value)` instead of `value`

And `auto` could be handled based on a target and current temperature comparison.

Thanks @robertklep, here is a successfully tested solution to handle better `AUTO` mode: https://github.com/OlivierZal/com.swttt.homekit/commit/446e9a7e4a4c31dbcec96831f2fed9a67e4e4fdb I'm open to any comment or suggestion.

@bradzacher, > Having .js files is rare in a modern TS codebase and they're usually only there because you're using a tool that doesn't support TS (eg nodejs entrypoints or...

Thank you very much @robertklep! Rebasing my fork on the 4.3.0 fixed it without having to reset any device.

However I forgot to precise that I needed to upgrade the `package-lock.json` to make it work locally: https://github.com/OlivierZal/com.swttt.homekit/pull/1/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519R9 (https://github.com/OlivierZal/com.swttt.homekit/blob/44111ae7ed5102dba27eb9ace3782ed4b64393f7/package-lock.json#L9)

I can do the PR if you want, is there a release branch?

@ljharb, I don't know the exact process on this project, but here's a PR from a fork: https://github.com/airbnb/javascript/pull/2818/files