Olivier Zalmanski

Hi @robertklep, thanks for your quick answer. I contacted MELCloud app creator, who answered that solution should rather be on HomeyKit’s side than on its side: https://github.com/XattSPT/com.melcloud/issues/30#issuecomment-1014832682 What would be...

I understand.

If I well understand: - thermostat or any mode is retrieved from [this line](https://github.com/swttt/com.swttt.homekit/blob/7445104b693e6e6a1aacfec3d8feb9ac0856d908/lib/devices/thermostat.js#L102), so that we should append to the `device.capabilities` list any feature not belonging to `.capabilities` -...

Hi @robertklep, would you agree with [this](https://github.com/swttt/com.swttt.homekit/pull/233/files)? Would it be possible to use/test it locally?

Thanks @robertklep for having a look 😊 Indeed I made a PR but it was more for a design discussion basis 😅 I guess we could restrict the capability conditions...

Thank you very much @robertklep. I can install and run locally.

@robertklep, I made some tests, and I succeed in making it work. However, I don't really get the use cases where we need to use `addCharacteristics` versus `getCharacteristics` (both seem...

Yes, everything is defined in `node_modules/hap-nodejs/lib/gen/HomeKitTypes.js` and also saw the method definition talking about the need to create an instance sometimes, but actually I don't see any difference of behaviour....

and the HomeyKit code does not always respect this rule, e.g. https://github.com/swttt/com.swttt.homekit/blob/master/lib/devices/thermostat.js#L66, although we have: ``` Service.Thermostat = function(displayName, subtype) { Service.call(this, displayName, '0000004A-0000-1000-8000-0026BB765291', subtype); // Required Characteristics this.addCharacteristic(Characteristic.CurrentHeatingCoolingState); this.addCharacteristic(Characteristic.TargetHeatingCoolingState);...

Hi @robertklep, so now I understand and manage better how it works... so that I found a bug: https://github.com/OlivierZal/com.swttt.homekit/commit/34c0f54a750b4be7d6e1645585c9462489f5c14e#diff-ab23aceaf01d9610b779f2ff02399f98c76b4a54185cc38254500e6e97e70ef5R273 it should be `thermostat.getCharacteristic(Characteristic.TargetHeatingCoolingState).update(state2value(value))` since: - `value` is either `off`, `heat`,...