Olivier Nicole comments

Results 346 comments of


                                            Olivier Nicole

Fixes a false warning thrown when compiling with --enable-tsan

Sorry this is not correct. A more accurate summary is: `-fsanitize=thread` should be part of `CFLAGS`. The `CFLAGS` should be passed to all the commands that need them. If this...

Attempt at a thread-safe implementation of DLS

I am reviewing this.

Attempt at a thread-safe implementation of DLS

It looks like the test creates too many threads on i386. Maybe the number could be a bit lower?

Attempt at a thread-safe implementation of DLS

> What sort of protection do you actually have in mind? > > * If you mean "failing when concurrent initialization is detected", I believe that this is the wrong...

Attempt at a thread-safe implementation of DLS

> @OlivierNicole we have had detailed discussions of the code and your review comments since after you made your review. Does your initial "approval" still stands? I was about to...

Attempt at a thread-safe implementation of DLS

> However I am not suggesting to do this in the general way (a new module and all) in the context of the present PR, because I am tired of...

Attempt at a thread-safe implementation of DLS

Ah, yes. In native code only recursive functions contain poll points, right?

Attempt at a thread-safe implementation of DLS

> Note: I also discussed this problem (how the heck can we write thread-safe programs?) with @gadmm this week. One suggestion he made is to implement a "single-threaded atomics" module...

add more modules to `StdLabels` / `MoreLabels`

For the record, I personally do care about the labelled modules. I also recall a few posts on Discuss of people saying they like to use them. If there is...

Add `Stdlib.todo`

I like the current design. I agree with @dbuenzli and @yawaramin that the alert should be disabled by default (I believe @yawaramin pointed to how to do that). > 2....